Page 1 of 1

[fixed] Bug: Sparkle: copies extra particles!!!

PostPosted: Saturday, 14.December 2013, 14:18
by Skinnytorus
Very strange behavior here. Sparkle copies 1 initial particle several times. It shouldn't happen.
Take a look at the example and copy-paste the stack into original wz4. There it behaves fine.

Re: Bug: Sparkle: copies extra particles!!!

PostPosted: Saturday, 14.December 2013, 17:05
by Skinnytorus
In fact, this is what causes it:
https://github.com/wzman/werkkzeug4CE/c ... 803e27099e
wz4/wz4frlib/fxparticle.cpp,

Replace p->Init(s->Pos+s->Speed*t+g*t*t,t) with p->Init(s->Pos+s->Speed*t+g*t*t,tt) and everything returns to normal.
I just wonder if this 'fix' is harmless for the rest of the code...

Re: Bug: Sparkle: copies extra particles!!!

PostPosted: Tuesday, 17.December 2013, 10:14
by ikam
Yes it is a good fix.
It seems to be a mistake when I commited this modif.
I updated the fix.
Thanks.

Re: Bug: Sparkle: copies extra particles!!!

PostPosted: Tuesday, 17.December 2013, 18:13
by Skinnytorus
Fine. Thanks. :)