[fixed] Bug: Open Backup doesn't recall backup file name

[fixed] Bug: Open Backup doesn't recall backup file name

Postby Skinnytorus » Saturday, 14.September 2013, 12:32

To repro:
1. Open some file (file1)
2. Open backup of another file (file2)
3. See that the file name of the backup file is file1 (not file2) which is incorrect.
Skinnytorus
Operator
Operator
 
Posts: 1300
Joined: Monday, 06.February 2012, 17:46

Re: Bug: Open Backup doesn't recall backup file name

Postby ikam » Monday, 16.September 2013, 14:23

In a way, this could be a correct behavior if you open a backup of the file1. It auto replace the filename, ready to save your doc with the last name.

In other way, It become inccorect if you open a backup of an other file that file1.

...

I can call the save as dialog just after to ask to rename the file, but it's quiet strange...
ikam
Operator
Operator
 
Posts: 911
Joined: Friday, 14.October 2011, 13:00
Location: France

Re: Bug: Open Backup doesn't recall backup file name

Postby Skinnytorus » Monday, 16.September 2013, 14:32

Does wz save filename into the backup file? IMHO, on opening wz should read filename from the backup file (i.e. file2). There are lots of backup files in backup directory. Theoretically, you can choose to load any of them and not necessarily the last one. And the name of the backed up file and its name on load should be the same. Otherwise we have a mess..
Skinnytorus
Operator
Operator
 
Posts: 1300
Joined: Monday, 06.February 2012, 17:46

Re: Bug: Open Backup doesn't recall backup file name

Postby ikam » Monday, 16.September 2013, 14:48

I think it was made like that to auto recover the last file. But not adapted to search an old backup, even if this is possible...
We can ever use open for that and search in the backup...

But I'm agree that if you open an old backup, it will reuse the filename of your previous file which is dangerous if you overwrite it...
ikam
Operator
Operator
 
Posts: 911
Joined: Friday, 14.October 2011, 13:00
Location: France

Re: Bug: Open Backup doesn't recall backup file name

Postby ikam » Monday, 16.September 2013, 14:52

Ok, as it is dangerous, I will reuse the backup filename.
ikam
Operator
Operator
 
Posts: 911
Joined: Friday, 14.October 2011, 13:00
Location: France

Re: Bug: Open Backup doesn't recall backup file name

Postby Skinnytorus » Monday, 16.September 2013, 15:03

Do you mean that you will use the actual filename for backup? I think the easiest way to do that is to add to filename something like "_bak#.wz4" on saving a backup copy of the file and then open it with its own filename (i.e. xyz_bak1.wz4). I think that would be sufficient to close the issue.
Skinnytorus
Operator
Operator
 
Posts: 1300
Joined: Monday, 06.February 2012, 17:46

Re: Bug: Open Backup doesn't recall backup file name

Postby Skinnytorus » Monday, 16.September 2013, 18:09

Yeah. The commit works fine. I mark the topic done. Many thanks.
Skinnytorus
Operator
Operator
 
Posts: 1300
Joined: Monday, 06.February 2012, 17:46


Return to Bug reports



Who is online

Users browsing this forum: No registered users and 2 guests

cron