[fixed] Bug: Sparkle: copies extra particles!!!

[fixed] Bug: Sparkle: copies extra particles!!!

Postby Skinnytorus » Saturday, 14.December 2013, 14:18

Very strange behavior here. Sparkle copies 1 initial particle several times. It shouldn't happen.
Take a look at the example and copy-paste the stack into original wz4. There it behaves fine.
You do not have the required permissions to view the files attached to this post.
Skinnytorus
Operator
Operator
 
Posts: 1300
Joined: Monday, 06.February 2012, 17:46

Re: Bug: Sparkle: copies extra particles!!!

Postby Skinnytorus » Saturday, 14.December 2013, 17:05

In fact, this is what causes it:
https://github.com/wzman/werkkzeug4CE/c ... 803e27099e
wz4/wz4frlib/fxparticle.cpp,

Replace p->Init(s->Pos+s->Speed*t+g*t*t,t) with p->Init(s->Pos+s->Speed*t+g*t*t,tt) and everything returns to normal.
I just wonder if this 'fix' is harmless for the rest of the code...
Skinnytorus
Operator
Operator
 
Posts: 1300
Joined: Monday, 06.February 2012, 17:46

Re: Bug: Sparkle: copies extra particles!!!

Postby ikam » Tuesday, 17.December 2013, 10:14

Yes it is a good fix.
It seems to be a mistake when I commited this modif.
I updated the fix.
Thanks.
ikam
Operator
Operator
 
Posts: 911
Joined: Friday, 14.October 2011, 13:00
Location: France

Re: Bug: Sparkle: copies extra particles!!!

Postby Skinnytorus » Tuesday, 17.December 2013, 18:13

Fine. Thanks. :)
Skinnytorus
Operator
Operator
 
Posts: 1300
Joined: Monday, 06.February 2012, 17:46


Return to Bug reports



Who is online

Users browsing this forum: No registered users and 8 guests

cron